(CAT-1521) - Adding new OS RHEL-9 ARM #530
Merged
+15
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ramesh7 would matrix_from_metadata also need updated? puppet_litmus/exe/matrix_from_metadata_v2 Line 30 in affb26d also, it would be good to add a spec test for this here: https://github.com/puppetlabs/puppet_litmus/blob/main/spec/exe/matrix_from_metadata_v2_spec.rb |
Thanks @GSPatton for review, have addressed the comments, ready to re-review. |
jordanbreen28
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Nice one @Ramesh7. Tested this using the values from matrix_from_metadata_v2 and it all seems to work.
I'll kick off the release job.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Agent Team have certified puppet agent with FOSS RHEL-9-ARM so we need to add for module testing as well.
Additional Context
Related Issues (if any)
N/A
Checklist